Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge staging to master #9

Merged
merged 14 commits into from
Sep 27, 2023
Merged

ci: merge staging to master #9

merged 14 commits into from
Sep 27, 2023

Conversation

maxwell-aiden
Copy link
Member

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 992628662 for 7c54059

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/992628662

@maxwell-aiden maxwell-aiden self-assigned this Sep 5, 2023
CMCDragonkai and others added 4 commits September 7, 2023 17:14
WIPO

Adding matrix packages to package.json

WIP

Changing dir

WIP
* Errors added new error type and sig dec for RPCServer

RPCServer rewritten without PK dependency.

* New utils with isObj and promise methods implemented

middleware import fix

WIP

* Apparently fixing RPCServer.ts fixed all of import issues of RPCClient.ts as well, and client has no PK related imports now, so its fixed? #COPE

WIP

cping tests from pk to js-rpc

experimental Decorators and changing logger version

experimental Decorators and changing logger version

sleep in utils.ts

WIP

Test resolve

wip

wip
callers and handlers are now refactored

* WIP - Newline now works, refers issue #1

node v20 fix

feat: handlers implementations are now abstract arrow functions

* Fixes #5

[ci skip]

* resolves issue 5, makes RPC handlers abstract arrow function properties

feat: rename to uppercase

[ci skip]

fix: handler export fix

[ci skip]

fix: tsconf from quic

[ci skip]

fix: dependencies (js quic), events and errors versions, changing to relative imports, jest dev dependency, js-quic tsconfig

[ci skip]

fix: tests imports, using @

[ci skip]

chore: removed sysexits

chore: fix default exports for callers and handlers
Fixed index for handlers

fix: remove @matrixai/id

fix: remove @matrixai/id and ix

chore : diagram

[ci skip]

chore : lintfix
fix: errors now extend AbstractError

[ci skip]

fix: undoing fix #1

[ci skip]

replacd errorCode with just code, references std error codes from rpc spec

feat: events based createDestroy

[ci skip]

chore: img format fix

[ci skip]

chore: img in README.md

[ci skip]

feat: allows the user to pass in a generator function if the user wishes to specify a particular id

[ci skip]

fix: fixes #7

* Removes graceTimer and related jests

chore: idGen name change. idGen parameter in creation and constructor. No longer optional. Only defaulted in one place.

wip: added idgen to jests, was missing.

[ci skip]

wip: reimported ix, since a few tests rely on it.
removed, matrixai/id

wip: jests for #4
removed, matrixai/id

wip: * Implements custom RPC Error codes.
     * Fixed jest for concurrent timeouts
     * All errors now have a cause
     * All errors now use custom error codes.

wip: *Client uses ctx timer now

wip: *Jests to test concurrency

wip: *custom RPC based errors for RPC Client, now all errors have a cause and an error message

WIP: * Refactor out sensitiveReplacer

WIP: * Refactor out sensitiveReplacer

WIP: * Update to latest async init and events
* set default timeout to Infinity
* jest to check server and client with infinite timeout
* fixing jests which broke after changing default timeout to infinity

WIP: f1x #4

WIP: f1x #11

f1x: parameterize toError, fromError and replacer

wip: tofrom

fix: parameterize toError, fromError and replacer

fix: Makes concurrent jests non deterministic

* Related #4

fix: parameterize replacer toError and fromError, change fromError to return JSONValue, stringify fromError usages

* Related #10

fix: Converted global state for fromError to handle it internally.

*Related: #10
Reviewed-by: @tegefaulkes
[ci skip]

chore: Jests for fromError and toError, and using a custom replacer.

related: #10

[ci skip]
@ghost
Copy link

ghost commented Sep 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@CMCDragonkai
Copy link
Member

Add cicd as a remote, push up to staging cicd if you want to trigger the CI faster.

@CMCDragonkai
Copy link
Member

Like this:

git remote add cicd [email protected]:MatrixAI/open-source/js-rpc.git

But make sure you're always pushing to github first before gitlab.

@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 1016517412 for b091f73

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1016517412

fix: jests related to toError and fromError
@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 1016855848 for f2cba9e

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1016855848

@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 1017775372 for faf5daf

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1017775372

@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 1017803216 for 33162c8

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1017803216

@maxwell-aiden
Copy link
Member Author

Pipeline Attempt on 1017810146 for 1125783

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1017810146

@maxwell-aiden
Copy link
Member Author

Pipeline Succeeded on 1017810146 for 1125783

https://gitlab.com/MatrixAI/open-source/js-rpc/-/pipelines/1017810146

@maxwell-aiden maxwell-aiden merged commit 1125783 into master Sep 27, 2023
addievo pushed a commit that referenced this pull request Oct 9, 2023
# This is the 1st commit message:

fix: RPCServer.start is now no longer a factory function

fix: fixed RPC tests after async-init change

# This is the commit message #2:

chore: updated inline documentation according to async-init changes

# This is the commit message #3:

wip: fixing imports

# This is the commit message #4:

wip: RPCServer deconstruction

# This is the commit message #5:

fix: RPCServer start stop order

# This is the commit message #6:

fix: added back createDestroy back to RPCClient

# This is the commit message #7:

chore: lintfix

# This is the commit message #8:

wip: completely removed create destroy from rpcclient

# This is the commit message #9:

fix: RPCClient tests after async-init changes

# This is the commit message #10:

wip

# This is the commit message #11:

fix: idgen is optional in constructor

# This is the commit message #12:

fix: type import in ./types

# This is the commit message #13:

chore: test for RPCServer force stopping

# This is the commit message #14:

fix: proper implementation of fromError toError, clientOutputTransformStream no longer outputs error.data, but rather error directly

# This is the commit message #15:

fix: jest fix for ErrorRPCRemote

# This is the commit message #16:

wip toError fromError

fix: proper implementation of fromError toError, clientOutputTransformStream no longer outputs error.data, but rather error directly

fix: changed rpcClient toError implementation

fix: changing ErrorRPCRemote constructor to be in-line with toError error creation constructor

fix: jest fix for ErrorRPCRemote

fix: fixing exports

fix: RPC errors now correctly extend AbstractError

fix: removed old events
fix: cleaned up imports
feat: client has toError as parameter
fix: removed type from JSONError obj
fix: startStop constructor correctly used
fix: infinity is definitely not == 1 minute

chore:  rename variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants