Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated footer #6

Merged
merged 2 commits into from
Oct 13, 2020
Merged

updated footer #6

merged 2 commits into from
Oct 13, 2020

Conversation

bineetNaidu
Copy link
Contributor

-- add fontawesome for icons
-- add footer styles
-- copied gamergram.ico to src for footer img

bineetNaidu and others added 2 commits October 13, 2020 11:00
@bineetNaidu
-- updated footer
4ca59fd 
-- add fontawesome for icons
-- add footer styles
-- copied gamergram.ico to src for footer img
@bineetNaidu
Merge branch 'master' into issue#3
57418ba
@MeghalBisht
Copy link
Owner

@bineetNaidu Please add screenshot for the same! Then I will merge it

@bineetNaidu
Copy link
Contributor Author

@bineetNaidu Please add screenshot for the same! Then I will merge it

how i will i add the screenshot i mean it has to on the projects folder right??

@MeghalBisht
Copy link
Owner

@bineetNaidu Run the app on your local, take a screenshot of the footer and while adding a comment here, there is an option to "attach files by dragging and dropping".
2020-10-13 (4)_LI

@bineetNaidu
Copy link
Contributor Author

bineetNaidu commented Oct 13, 2020 •
edited
Loading

Screenshot from 2020-10-13 11-57-28
here is the screen shot of the PR .

Any other change u can feel free to tell me. 👍

@MeghalBisht MeghalBisht merged commit 018390b into MeghalBisht:master Oct 13, 2020
@MeghalBisht
Copy link
Owner

@bineetNaidu Looks awesome! Thanks, will add you to the contributors list once I make it. Thanks a lot 👍

@MeghalBisht MeghalBisht added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktober fest accepted, I will merge once PR is submitted hacktoberfest-accepted Hacktober fest accepted, I will merge once PR is submitted hacktoberfest2020 Hacktober fest accepted, I will merge once PR is submitted labels Oct 13, 2020
@MeghalBisht MeghalBisht linked an issue Oct 13, 2020 that may be closed by this pull request
Footer Component #3
Closed
@bineetNaidu
Copy link
Contributor Author

Thanks a lot. In future is you need any help you can always ask.

@MeghalBisht
Copy link
Owner

@bineetNaidu Yes I am opening one issue for Contributors page where names and images of all contributors would be displayed.
If you want I can assign you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktober fest accepted, I will merge once PR is submitted hacktoberfest2020 Hacktober fest accepted, I will merge once PR is submitted hacktoberfest-accepted Hacktober fest accepted, I will merge once PR is submitted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer Component
2 participants
@bineetNaidu @MeghalBisht