Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ol-webgl-tile-layer doesn't react to opacity anymore (regression in 6.1.2) #319

Closed
pwuertz opened this issue Mar 23, 2024 · 0 comments · Fixed by #320
Closed

ol-webgl-tile-layer doesn't react to opacity anymore (regression in 6.1.2) #319

pwuertz opened this issue Mar 23, 2024 · 0 comments · Fixed by #320
Labels
bug Something isn't working

Comments

@pwuertz
Copy link

pwuertz commented Mar 23, 2024

Describe the bug
Upgrading from release 6.1.1 to 6.1.2 (i.e. commit 974f155) introduced a regression in ol-webgl-tile-layer. Binding an opacity value like <ol-webgl-tile-layer :opacity="value" ...> still works for the initial value, but it seems like changes to value aren't propagated to the layer anymore. The layer opacity stays at its initial level.

Affected version(s)
Dynamic opacity still works in 6.1.1, and stops working in 6.1.2.

To Reproduce
Steps to reproduce the behavior:

  • Create a scene with an <ol-webgl-tile-layer :opacity="value" ...>
  • Bind value to a slider and modify it

Desktop (please complete the following information):

  • Browser: Firefox, Chrome

Additional context
Tested with OpenLayers 9.0 and 9.1
@pwuertz pwuertz added the bug Something isn't working label Mar 23, 2024
d-koppenhagen added a commit that referenced this issue Mar 25, 2024
@d-koppenhagen
fix(ol-webgl-tile-layer): react on property changes
66fb52e 
- make TileLayer a shallowRef, to not always create a new class
- apply property changes using `.set('<prop>', value)`
- add demo for opacity / visibility changes

closes #319
@d-koppenhagen d-koppenhagen mentioned this issue Mar 25, 2024
Merged
15 tasks
d-koppenhagen added a commit that referenced this issue Mar 25, 2024
@d-koppenhagen
fix(ol-webgl-tile-layer): react on property changes
bdfcab6 
- make TileLayer a shallowRef, to not always create a new class
- apply property changes using `.set('<prop>', value)`
- add demo for opacity / visibility changes

closes #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ol-webgl-tile-layer): react on property changes MelihAltintas/vue3-openlayers
1 participant
@pwuertz