-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(4243): add doc for create an analystics event from extension #126
base: main
Are you sure you want to change the base?
Conversation
d406bb9
to
51f981d
Compare
Thanks a lot @DDDDDanica for kicking off the tutorial on analytics in Extension! |
|
||
## Prerequisites | ||
|
||
- Before you begin, please refer to this [Working with Event Metrics](https://www.notion.so/consensys/Working-with-Event-Metrics-3b0b5a4308e64649a54a2864886c0412) and make sure you understand the context of the analytics events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: is this Notion page public for external contributors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not public but critical for the context, wdyt? should we move this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we copy it as MD in this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of charts stuff. IMO external contributor won't add a metric event, we can remove this. wdyt?
}); | ||
``` | ||
|
||
#### 2.4. Validate the Event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: optional if user has access, but helps sometimes to detect issues, we should also check for the event in a Mixpanel dev dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea ! can you show me the link of Mixpanel i can add to it, so far i just found some recordings for testing, thanks a lot !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have to access it (only for internal) using their Okta dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad, i mean link of Mixpanel document ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @DDDDDanica!
I approve even with the few possible improvements.
Feel free to fix them but maybe we are better merging this first and then improve it.
Create a new contributor-docs explaining minimum knowledge required to create an analytics event in the MetaMask extension codebase.