Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(4243): add doc for create an analystics event from extension #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DDDDDanica
Copy link
Contributor

Create a new contributor-docs explaining minimum knowledge required to create an analytics event in the MetaMask extension codebase.

@DDDDDanica DDDDDanica self-assigned this Feb 21, 2025
@DDDDDanica DDDDDanica requested a review from a team as a code owner February 21, 2025 02:27
@gauthierpetetin
Copy link
Contributor

Thanks a lot @DDDDDanica for kicking off the tutorial on analytics in Extension!
@NicolasMassart since you have worked a lot on analytics, it would be great to have your insights as well, so I added you as a reviewer. We will also need to include content for analytics in Mobile, probably in the same PR. We can discuss this during the weekly review.


## Prerequisites

- Before you begin, please refer to this [Working with Event Metrics](https://www.notion.so/consensys/Working-with-Event-Metrics-3b0b5a4308e64649a54a2864886c0412) and make sure you understand the context of the analytics events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is this Notion page public for external contributors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not public but critical for the context, wdyt? should we move this out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we copy it as MD in this repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of charts stuff. IMO external contributor won't add a metric event, we can remove this. wdyt?

});
```

#### 2.4. Validate the Event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: optional if user has access, but helps sometimes to detect issues, we should also check for the event in a Mixpanel dev dashboard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea ! can you show me the link of Mixpanel i can add to it, so far i just found some recordings for testing, thanks a lot !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have to access it (only for internal) using their Okta dashboard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad, i mean link of Mixpanel document ...

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @DDDDDanica!
I approve even with the few possible improvements.
Feel free to fix them but maybe we are better merging this first and then improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants