Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent external transactions to internal accounts if data included #5418

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 3, 2025

Explanation

Update validation preventing external transactions to internal accounts to only throw if data is included in the parameters.

References

Changelog

See CHANGELOG.md.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "24.1.0-preview-af470a9",
  "@metamask-previews/address-book-controller": "6.0.3-preview-af470a9",
  "@metamask-previews/announcement-controller": "7.0.3-preview-af470a9",
  "@metamask-previews/approval-controller": "7.1.3-preview-af470a9",
  "@metamask-previews/assets-controllers": "51.0.2-preview-af470a9",
  "@metamask-previews/base-controller": "8.0.0-preview-af470a9",
  "@metamask-previews/bridge-controller": "2.0.0-preview-af470a9",
  "@metamask-previews/bridge-status-controller": "2.0.0-preview-af470a9",
  "@metamask-previews/build-utils": "3.0.3-preview-af470a9",
  "@metamask-previews/composable-controller": "11.0.0-preview-af470a9",
  "@metamask-previews/controller-utils": "11.5.0-preview-af470a9",
  "@metamask-previews/earn-controller": "0.5.0-preview-af470a9",
  "@metamask-previews/ens-controller": "15.0.2-preview-af470a9",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-af470a9",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-af470a9",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-af470a9",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-af470a9",
  "@metamask-previews/keyring-controller": "19.2.1-preview-af470a9",
  "@metamask-previews/logging-controller": "6.0.4-preview-af470a9",
  "@metamask-previews/message-manager": "12.0.1-preview-af470a9",
  "@metamask-previews/multichain": "3.0.0-preview-af470a9",
  "@metamask-previews/multichain-network-controller": "0.1.2-preview-af470a9",
  "@metamask-previews/multichain-transactions-controller": "0.5.0-preview-af470a9",
  "@metamask-previews/name-controller": "8.0.3-preview-af470a9",
  "@metamask-previews/network-controller": "22.2.1-preview-af470a9",
  "@metamask-previews/notification-services-controller": "1.0.0-preview-af470a9",
  "@metamask-previews/permission-controller": "11.0.6-preview-af470a9",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-af470a9",
  "@metamask-previews/phishing-controller": "12.4.0-preview-af470a9",
  "@metamask-previews/polling-controller": "12.0.3-preview-af470a9",
  "@metamask-previews/preferences-controller": "15.0.2-preview-af470a9",
  "@metamask-previews/profile-sync-controller": "8.1.1-preview-af470a9",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-af470a9",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-af470a9",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-af470a9",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-af470a9",
  "@metamask-previews/signature-controller": "23.2.1-preview-af470a9",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-af470a9",
  "@metamask-previews/transaction-controller": "46.0.0-preview-af470a9",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-af470a9"
}

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review March 7, 2025 14:18
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 7, 2025 14:18
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "26.0.0-preview-22387993",
  "@metamask-previews/address-book-controller": "6.0.3-preview-22387993",
  "@metamask-previews/announcement-controller": "7.0.3-preview-22387993",
  "@metamask-previews/approval-controller": "7.1.3-preview-22387993",
  "@metamask-previews/assets-controllers": "53.0.0-preview-22387993",
  "@metamask-previews/base-controller": "8.0.0-preview-22387993",
  "@metamask-previews/bridge-controller": "5.0.0-preview-22387993",
  "@metamask-previews/bridge-status-controller": "5.0.0-preview-22387993",
  "@metamask-previews/build-utils": "3.0.3-preview-22387993",
  "@metamask-previews/composable-controller": "11.0.0-preview-22387993",
  "@metamask-previews/controller-utils": "11.6.0-preview-22387993",
  "@metamask-previews/earn-controller": "0.7.0-preview-22387993",
  "@metamask-previews/ens-controller": "15.0.2-preview-22387993",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-22387993",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-22387993",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-22387993",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-22387993",
  "@metamask-previews/keyring-controller": "21.0.0-preview-22387993",
  "@metamask-previews/logging-controller": "6.0.4-preview-22387993",
  "@metamask-previews/message-manager": "12.0.1-preview-22387993",
  "@metamask-previews/multichain": "4.0.0-preview-22387993",
  "@metamask-previews/multichain-network-controller": "0.2.0-preview-22387993",
  "@metamask-previews/multichain-transactions-controller": "0.7.0-preview-22387993",
  "@metamask-previews/name-controller": "8.0.3-preview-22387993",
  "@metamask-previews/network-controller": "22.2.1-preview-22387993",
  "@metamask-previews/notification-services-controller": "3.0.0-preview-22387993",
  "@metamask-previews/permission-controller": "11.0.6-preview-22387993",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-22387993",
  "@metamask-previews/phishing-controller": "12.4.0-preview-22387993",
  "@metamask-previews/polling-controller": "12.0.3-preview-22387993",
  "@metamask-previews/preferences-controller": "17.0.0-preview-22387993",
  "@metamask-previews/profile-sync-controller": "10.0.0-preview-22387993",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-22387993",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-22387993",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-22387993",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-22387993",
  "@metamask-previews/signature-controller": "25.0.0-preview-22387993",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-22387993",
  "@metamask-previews/transaction-controller": "48.0.0-preview-22387993",
  "@metamask-previews/user-operation-controller": "27.0.0-preview-22387993"
}

@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) March 11, 2025 09:52
@matthewwalsh0 matthewwalsh0 merged commit 590fb36 into main Mar 11, 2025
136 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/internal-account-validation-data branch March 11, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants