Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated refreshPooledStakingVaultDailyApys days arg default value to 365 #5453

Merged
merged 2 commits into from
Mar 11, 2025
Merged

feat: updated refreshPooledStakingVaultDailyApys days arg default value to 365 #5453

merged 2 commits into from
Mar 11, 2025

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Mar 10, 2025

Explanation

This PR updates the default days value from 30 to 365 when refreshing pooled staking vault apys. This means we pull one year worth of apys by default.

References

Changelog

@metamask/earn-controller

  • CHANGED: Updated refreshPooledStakingVaultDailyApys days argument default value from 30 to 365

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Matt561 Matt561 force-pushed the feat/earn-controller-update-refresh-pooled-staking-vault-daily-apys-days-query-param branch from 0010098 to e2ad87d Compare March 10, 2025 17:12
@Matt561 Matt561 marked this pull request as ready for review March 10, 2025 17:12
@Matt561 Matt561 requested a review from a team as a code owner March 10, 2025 17:12
nickewansmith
nickewansmith approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matt561 Matt561 enabled auto-merge (squash) March 11, 2025 16:42
@Matt561 Matt561 merged commit 3f1c6c3 into main Mar 11, 2025
136 checks passed
@Matt561 Matt561 deleted the feat/earn-controller-update-refresh-pooled-staking-vault-daily-apys-days-query-param branch March 11, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickewansmith nickewansmith nickewansmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt561 @nickewansmith