Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add RecommendedAction to export #5456

Merged
merged 3 commits into from
Mar 11, 2025
Merged

chore: add RecommendedAction to export #5456

merged 3 commits into from
Mar 11, 2025

Conversation

imblue-dabadee
Copy link
Contributor

Explanation

RecommendedAction is needed to be added to the export to be used appropriately and tested for clients that use scanUrl.

References

Changelog

@metamask/phishing-controller

  • FIXED: Correctly adds RecommendedAction

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@imblue-dabadee imblue-dabadee marked this pull request as ready for review March 11, 2025 11:42
@imblue-dabadee imblue-dabadee requested a review from a team as a code owner March 11, 2025 11:42
@imblue-dabadee imblue-dabadee merged commit 943fa70 into main Mar 11, 2025
136 checks passed
@imblue-dabadee imblue-dabadee deleted the chore/add-RecommendedAction-to-export branch March 11, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imblue-dabadee @cryptotavares