Fix dependency-related constraints

[mcmire]

Explanation

I've noticed recently that it is impossible to add a controller dependency just to dependencies; one of our existing constraints demands that it also be added to peerDependencies. This is obviously incorrect.

This commit addresses this (and other related constraints) by the following:

• Remove expectControllerDependenciesListedAsPeerDependencies. This is the faulty constraint referred to above.
• Correct expectDependenciesNotInBothProdAndDev (now expectDependenciesNotInBothProdAndDevOrPeer) to not only ensure that a dependency is not listed in both dependencies and devDependencies but also both dependencies and peerDependencies (only devDependencies + peerDependencies is allowed, as combinations go).
• Add expectPeerDependenciesAlsoListedAsDevDependencies constraint to ensure that peer dependencies are also listed as dev dependencies.
• Fix expectUpToDateWorkspaceDependenciesAndDevDependencies to skip validation of "production" dependencies that are also listed in peer dependencies (this avoids conflicting constraints).
• Correct expectConsistentDependenciesAndDevDependencies to skip workspace dependencies, as that is already being handled by expectUpToDateWorkspaceDependenciesAndDevDependencies (this avoids conflicting constraints).

Note that because of these changes, several controllers have also been
corrected to fit.

References

(N/A)

Manual testing steps

• It should be possible to add a controller package to dependencies without needing to add it to peerDependencies. To test this:
  • Add "@metamask/permission-controller": "^11.0.6", to dependencies in the manifest for @metamask/accounts-controller
  • Run yarn constraints
  • You should not see any errors.
• It should not be possible to add a package to both dependencies and peerDependencies. To test this:
  • Add "@metamask/permission-controller": "^11.0.6", to dependencies and peerDependencies in the manifest for @metamask/accounts-controller
  • Run yarn constraints
  • You should see an error.
• It should not be possible to add a package to just peerDependencies (it must also be present in devDependencies). To test this:
  • Add "@metamask/permission-controller": "^11.0.6", to just peerDependencies in the manifest for @metamask/accounts-controller
  • Run yarn constraints
  • You should see an error asking to also add the package to dependencies.
  • Change the line to "@metamask/controller-utils": "^11.6.0",
  • Run yarn constraints
  • You should still see an error asking to also add the package to dependencies.

Changelog

(Updated in PR.)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mcmire]

Not related to this PR, but it had been a while since I'd worked on this file, and this description was confusing.

[cryptodev-2s]

LGTM!

[ccharly]

LGTM for accounts-related files 👍

[infiniteflower]

Looks good for Swaps/Bridge