Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bridge bridge status controller env config #5465

Merged
merged 5 commits into from
Mar 13, 2025

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Mar 12, 2025

Explanation

This PR change the way a custom and dev urls are passed into the Bridge and BridgeStatus controllers. Before it was through process.env, but to support Mobile development, it has been changed to a config variable in the constructor.

References

Changelog

@metamask/bridge-controller

  • BREAKING: Changing Bridge API urls now occurs through the constructor's config field, rather than through process.env.BRIDGE_CUSTOM_API_BASE_URL and process.env.BRIDGE_USE_DEV_APIS
  • BREAKING: getBridgeApiBaseUrl no longer exported
  • CHANGED: BRIDGE_DEV_API_BASE_URL, BRIDGE_PROD_API_BASE_URL now exported

@metamask/bridge-status-controller

  • BREAKING: Changing Bridge API urls now occurs through the constructor's config field, rather than through process.env.BRIDGE_CUSTOM_API_BASE_URL and process.env.BRIDGE_USE_DEV_APIS

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@infiniteflower infiniteflower marked this pull request as ready for review March 12, 2025 22:34
@infiniteflower infiniteflower requested a review from a team as a code owner March 12, 2025 22:34
@infiniteflower infiniteflower marked this pull request as draft March 12, 2025 22:34
@infiniteflower infiniteflower marked this pull request as ready for review March 12, 2025 22:42
@infiniteflower infiniteflower enabled auto-merge (squash) March 13, 2025 16:42
@infiniteflower infiniteflower merged commit aa60352 into main Mar 13, 2025
136 checks passed
@infiniteflower infiniteflower deleted the feat/bridge-bridgeStatus-controller-env-config branch March 13, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants