Feat/bridge bridge status controller env config #5465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR change the way a custom and dev urls are passed into the Bridge and BridgeStatus controllers. Before it was through
process.env
, but to support Mobile development, it has been changed to a config variable in the constructor.References
Changelog
@metamask/bridge-controller
config
field, rather than throughprocess.env.BRIDGE_CUSTOM_API_BASE_URL
andprocess.env.BRIDGE_USE_DEV_APIS
getBridgeApiBaseUrl
no longer exportedBRIDGE_DEV_API_BASE_URL
,BRIDGE_PROD_API_BASE_URL
now exported@metamask/bridge-status-controller
config
field, rather than throughprocess.env.BRIDGE_CUSTOM_API_BASE_URL
andprocess.env.BRIDGE_USE_DEV_APIS
Checklist