feat: handle primary SRP switch cases #5478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We discovered that users leverage the "forgot password" flow to switch their primary SRPs in clients.
This is breaking auth & user storage, and this PR fixes that so that our controller can handle use cases where the primary SRP changes to another one.
Additional changes in clients should be made:
Please note that no changes in this PR introduces breaking changes.
References
Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-60
Changelog
@metamask/profile-sync-controller
AuthenticationController
doesn't use the_snapPublicKeyCache
anymore.UserStorageController
storageKeyCache
can now hold multiple values.SDK
getStorageKey
now takes amessage
argument for cache navigation purposesSDK
setStorageKey
now takes an additionalmessage
argument to leverage cache usagesChecklist