PollingBlockTracker: Stop wrapping errors #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not presently use this class in any repo under the MetaMask organization. In general we have found a polling-based approach to be more reliable than a subscription-based approach.
If PollingBlockTracker fails to make a request, the error is wrapped with a marker a more descriptive message (including the stack trace) before being emitted under the "error" event or logged. This wrapping may have been added in the past to assist with debugging, but it is not necessary now, and it complicates the tests.
mcmire
commented
Mar 11, 2025
| console.error(newErr); | ||
| this.emit('error', error); | ||
| } catch { | ||
| console.error(`Error updating latest block: ${getErrorMessage(error)}`); |
There was a problem hiding this comment.
Question: Do we even need to log the error anymore? Can we just let the error be thrown here if there are no "error" listeners? (This error would manifest as an unhandled rejection, but we could catch it in the polling loop so it doesn't leak out.)
mcmire
commented
Mar 12, 2025
| ); | ||
| }); | ||
|
|
||
| it(`should emit the "error" event (added via \`${methodToAddListener}\`) and should not throw if, while making the request for the latest block number, the provider throws a string`, async () => { |
There was a problem hiding this comment.
Previously we had tests which verified that the error message produced when the thrown error was a string was different from when the thrown error was an Error. Because we've simplified how error messages are stringified, we don't need to do this anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PollingBlockTracker fails to make a request, the error is wrapped with a marker and a more descriptive message (including the stack trace) before being emitted under the "error" event or logged. This wrapping may have been added in the past to assist with debugging, but it is not necessary now, and it complicates the tests.