Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wallet_*snap methods to Snaps docs #1286

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Apr 22, 2024

Description

Move wallet_snap, wallet_invokeSnap, wallet_getSnaps, and wallet_requestSnap docs to a new reference page in the Snaps docs, "Wallet API for Snaps." Update context and links accordingly.

Also see MetaMask/api-specs#218, which removes these methods from the interactive reference.

Issue(s) fixed

Fixes #1283

Preview

https://docs.metamask.io/1283-move-snaps-methods/snaps/reference/wallet-api-for-snaps/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@alexandratran alexandratran requested review from Montoya and vandan April 22, 2024 20:43
@alexandratran alexandratran requested review from a team as code owners April 22, 2024 20:43
Copy link

Preview published: 1283-move-snaps-methods

Copy link

Preview published: 1283-move-snaps-methods

Copy link

Preview published: 1283-move-snaps-methods

Copy link
Contributor

@vandan vandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as someone from Snaps can review the manually written API specs, everything else lgtm

Copy link
Collaborator

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but this page also needs to be updated: https://docs.metamask.io/snaps/how-to/connect-to-a-snap/

@alexandratran alexandratran requested a review from Montoya April 25, 2024 06:44
@alexandratran
Copy link
Contributor Author

@Montoya Good catch, fixed along with one other link

Copy link

Preview published: 1283-move-snaps-methods

Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 7ce52eb into main Apr 25, 2024
8 checks passed
@alexandratran alexandratran deleted the 1283-move-snaps-methods branch April 25, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move wallet_*snap API methods to Snaps docs
4 participants