-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wallet_*snap methods to Snaps docs #1286
Conversation
Preview published: 1283-move-snaps-methods |
Preview published: 1283-move-snaps-methods |
Preview published: 1283-move-snaps-methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as someone from Snaps can review the manually written API specs, everything else lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, but this page also needs to be updated: https://docs.metamask.io/snaps/how-to/connect-to-a-snap/
# Conflicts: # docs/whats-new.md
@Montoya Good catch, fixed along with one other link |
Preview published: 1283-move-snaps-methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Move
wallet_snap
,wallet_invokeSnap
,wallet_getSnaps
, andwallet_requestSnap
docs to a new reference page in the Snaps docs, "Wallet API for Snaps." Update context and links accordingly.Also see MetaMask/api-specs#218, which removes these methods from the interactive reference.
Issue(s) fixed
Fixes #1283
Preview
https://docs.metamask.io/1283-move-snaps-methods/snaps/reference/wallet-api-for-snaps/
Checklist
Complete this checklist before merging your PR: