Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK updates part 2: Add intro sections #1494

Merged
merged 63 commits into from
Oct 10, 2024
Merged

SDK updates part 2: Add intro sections #1494

merged 63 commits into from
Oct 10, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Aug 20, 2024 •
edited
Loading

Description

This PR:

  • Updates the Wallet landing page to highlight the SDK.
  • Adds a Connect to MetaMask section with SDK, third-party libraries, and Wallet API connection options.
  • Slightly restructures and edits related content.
  • Fixes links and redirects as necessary.

Will improve upon this restructure in additional PRs.

Issue(s) fixed

Fixes #1492

Preview

https://metamask-docs-l8trqpsxj-metamask-web.vercel.app/wallet/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 0:34am

@alexandratran alexandratran marked this pull request as ready for review August 21, 2024 06:15
@alexandratran alexandratran requested review from a team as code owners August 21, 2024 06:15
@alexandratran
Merge branch 'main' into 1492-SDK-part-2
153776e 
# Conflicts:
#	wallet/concepts/convenience-libraries.md
#	wallet/how-to/batch-json-rpc-requests.md
bgravenorst
bgravenorst previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback. Also, should we update the main landing page?

@alexandratran
Copy link
Contributor Author

@bgravenorst

Also, should we update the main landing page?

You're right, we should tweak the wording, but I'll open a separate PR for that because the Activation team will have to approve as codeowner.

bgravenorst
bgravenorst previously approved these changes Oct 10, 2024
View reviewed changes
@alexandratran alexandratran merged commit 804b3f7 into main Oct 10, 2024
17 checks passed
@alexandratran alexandratran deleted the 1492-SDK-part-2 branch October 10, 2024 00:37
@alexandratran alexandratran mentioned this pull request Oct 10, 2024
Merged
2 tasks
@alexandratran alexandratran mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgravenorst bgravenorst bgravenorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK updates part 2: add get started section
3 participants
@alexandratran @httpJunkie @bgravenorst