Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token search and discovery with swaps #13328

Open
wants to merge 131 commits into
base: main
Choose a base branch
from

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Feb 4, 2025

Description

This PR adds token search and discovery features to MetaMask:

  • browser URL bar now allows searching for tokens by name (prefix/autocomplete) and token address
  • users can swap directly from the search results (will switch or add the network if they don't have it)
  • users can see asset details for searched tokens, complete with price and market data
  • users can swap the found asset from the asset details page's swap button (will switch or add the network if they don't have it)

Screenshots/Recordings

After

token-search.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Bigshmow and others added 30 commits January 21, 2025 19:42
…etaMask/metamask-mobile into add-tokens-search-discovery-controller
@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 17, 2025
Copy link
Contributor

github-actions bot commented Mar 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4ae0f8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/24c47d7d-b931-4a39-89e3-dda9fef2822f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ca1d4dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7480695f-09d8-40dc-a28d-c277a71eb090

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 40cf225
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46971561-6eff-4cb9-8451-09b701e2a79a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dc9580e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1a2a0ff-6e8f-42af-b534-2b5d0f4e2280

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gitkit13 gitkit13 mentioned this pull request Mar 18, 2025
7 tasks
@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4995995
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ff09521e-4798-44c8-b22d-9cf6a569f1df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-portfolio
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

6 participants