-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Kanban Board #27
Comments
Good job so far! Suggested changesCheck the comments under the review. You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._ Things to consider:
Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. |
Thanks, @mcrd25 a lot for your time and for pointing out those things that we could have missed out on.
We agreed to separate tasks and the different parts of each task and wrote it down in the description. It was clear enough for us, but I'm curious about what you find not clear and how could I make it more clear for you. Could you please point me to one of the tasks that you don't think is well enough documented, please? Thanks a lot for your time. |
Hi,
I meant that your descriptions did not state what it is you were doing,
some of them just had a title ... so while I do believe that you most
likely considered every detail of project that's based on the requirements
however, for me it's kind of vague, like what does it mean when you say
front-end style. What are you accomplishing here?
So giving more detail in description would make it clearer- having a
description is also a requirement. So if guess that last comment was
summary of previous points.
But it seems like once you understood those points, everything should be
fine.
Sorry for the confusion.
…On Tue, Dec 7, 2021, 5:43 AM Abraham R ***@***.***> wrote:
Thanks a lot for your time and for pointing out those things that we could
have missed out on.
Everything was clear and well explained, except for this last point that
is signaling something I think I have done, but maybe it could be done
better:
- "Make sure that you have an issue corresponding to a project
requirement - Right now it is not clear simply because you don't always
give clear description of what's being done in those hours you've set for a
task"
We agreed to separate tasks and the different parts of each task and wrote
it down in the description. It was clear enough for us, but I'm curious
about what you find not clear and how could I make it more clear for you.
Could you please point me to one of the tasks that you don't think is well
enough documented, please?
Thanks a lot for your time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHN7VXZGU5HDBK44W5PJX3LUPXJLXANCNFSM5JOYXS6A>
.
|
Ok, we are reworking it to have more descriptively tasks showing in there. So the idea can be more clear. |
Hi @Metsanpeitto @AkashaRojee , In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it Good luck! 🎉 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. |
Oh, thanks a lot. :) |
Setup Kanban Board
Project: https://github.com/Metsanpeitto/microverse_final_project/projects/1
We are two people in this group:
@Metsanpeitto : Abraham Rodriguez
@AkashaRojee : Akasha Rojee
Kanban board screenshot
The text was updated successfully, but these errors were encountered: