Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Kanban Board #27

Open
Metsanpeitto opened this issue Dec 6, 2021 · 6 comments
Open

Setup Kanban Board #27

Metsanpeitto opened this issue Dec 6, 2021 · 6 comments

Comments

@Metsanpeitto
Copy link
Owner

Setup Kanban Board

Project: https://github.com/Metsanpeitto/microverse_final_project/projects/1

We are two people in this group:

@Metsanpeitto : Abraham Rodriguez
@AkashaRojee : Akasha Rojee

Kanban board screenshot

https://i.imgur.com/8G0sWBn.png

@mcrd25
Copy link

mcrd25 commented Dec 6, 2021

Hi @Metsanpeitto @AkashaRojee

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

Things to consider:

  • Not all of your issues have descriptions - this is required
  • [OPTIONAL] While I could tell which is BACK-END you can also consider labelling BACK-END the way you have done FRONT-END to make it consistent
  • [OPTIONAL] You can make use of the label feature in GitHub
    • Issue [2pt] FRONTEND - Create the styling #22 is not very specific, can you explain what is being done here? General style/color. Or are you setting up general styles for all pages where you'd get more specific for the individual pages in the other issues
  • Make sure that you have an issue corresponding to a project requirement - Right now it is not clear simply because you don't always give clear description of what's being done in those hours you've set for a task

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@Metsanpeitto
Copy link
Owner Author

Metsanpeitto commented Dec 7, 2021

Thanks, @mcrd25 a lot for your time and for pointing out those things that we could have missed out on.
Everything was clear and well explained, except for this last point that is signaling something I think I have done, but maybe it could be done better:

  • "Make sure that you have an issue corresponding to a project requirement - Right now it is not clear simply because you don't always give a clear description of what's being done in those hours you've set for a task"

We agreed to separate tasks and the different parts of each task and wrote it down in the description. It was clear enough for us, but I'm curious about what you find not clear and how could I make it more clear for you. Could you please point me to one of the tasks that you don't think is well enough documented, please?

Thanks a lot for your time.

@mcrd25
Copy link

mcrd25 commented Dec 7, 2021 via email

@Metsanpeitto
Copy link
Owner Author

Ok, we are reworking it to have more descriptively tasks showing in there. So the idea can be more clear.
Thanks a lot for your quick reply.

@mcrd25
Copy link

mcrd25 commented Dec 7, 2021

Hi @Metsanpeitto @AkashaRojee ,

In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it :shipit:

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Metsanpeitto
Copy link
Owner Author

Oh, thanks a lot. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants