Perf improvements #1517
Merged
Perf improvements #1517
+626
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Skip default extensions * Review comments * Unit tests * review comments
* Perf tests for Skip default adapters * review comments * review comments
* Donot initialize trace if specifically asked not to * For Testhost only Initialize Tracing if --diag is passed * test fix * Tracing for datacollector also to be initialized via --diag switch
abhishkk
approved these changes
Mar 28, 2018
acesiddhu
reviewed
Mar 28, 2018
| /// <returns>DiscoveryRequest object</returns> | ||
| IDiscoveryRequest CreateDiscoveryRequest(IRequestData requestData, DiscoveryCriteria discoveryCriteria); | ||
| IDiscoveryRequest CreateDiscoveryRequest(IRequestData requestData, DiscoveryCriteria discoveryCriteria, TestPlatformOptions options); |
There was a problem hiding this comment.
IDiscoveryRequest [](start = 8, length = 17)
this is a public interface. isnt this a breakingchange
There was a problem hiding this comment.
no this is not, since Tpv2 this Interface is not meant to be implemented by anyone outside vstest.console
If you see in ITestPlatform we have also made the class internal
acesiddhu
reviewed
Mar 28, 2018
| @@ -31,7 +31,7 @@ namespace Microsoft.VisualStudio.TestPlatform.Client | |||
| /// <summary> | |||
| /// Implementation for TestPlatform | |||
| /// </summary> | |||
| public class TestPlatform : ITestPlatform | |||
| internal class TestPlatform : ITestPlatform | |||
There was a problem hiding this comment.
internal [](start = 4, length = 8)
I am assuming adapters to customer havent taken a dependency on this.
There was a problem hiding this comment.
In reply to: 177697101 [](ancestors = 177697101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging Changes done for modifying adapter look up model in Translation Layer.