Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of subtract in many places #100

Closed
AlexCPU opened this issue Mar 10, 2023 · 1 comment
Closed

Correct spelling of subtract in many places #100

AlexCPU opened this issue Mar 10, 2023 · 1 comment

Comments

@AlexCPU
Copy link

AlexCPU commented Mar 10, 2023

I appreciate English isn't everyone's first language, so please don't take this the wrong way.
Could we get instances of "substract" corrected to "subtract" please?

I can submit a PR with a simple find+replace performed, but that would be a breaking change for peoples config, so if might be better to correct the spelling but keep supporting "substract_entities" for some time/forever, and I don't understand the code well enough to do that.

@MindFreeze
Copy link
Owner

Lol. I guess ai wrote it wrong once and copied it all over. Yea, it should be backwards compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants