Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .pop() to Chan as a complete alternative to .succ() and .zero(). #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
@@ -97,6 +97,23 @@ pub struct Z;
/// Peano numbers: Increment
pub struct S<N> ( PhantomData<N> );


trait Pop<N> {
type Head;
type Tail;
}

impl<A, B> Pop<Z> for (A, B) {
type Head = A;
type Tail = (A, B);
}

impl<A, B: Pop<N>, N> Pop<S<N>> for (A, B) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How well are trait impls for tuples supported? We did this once and found out that it was a bit of an unstable feature - but that might have been at that time...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's available in stable. :) Might have been an issue before the major coherence changes earlier this year.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it could be done with associated types like we're using for Send, Recv, etc.?

type Head = B::Head;
type Tail = B::Tail;
}


/// End of communication session (epsilon)
#[allow(missing_copy_implementations)]
pub struct Eps;
@@ -312,6 +329,14 @@ impl<E, P, N> Chan<(P, E), Var<S<N>>> {
}
}

impl<E: Pop<N>, N> Chan<E, Var<N>> {
/// Pop the environment, restoring the protocol N layers of recursion above us.
#[must_use]
pub fn pop(self) -> Chan<E::Tail, E::Head> {
Chan(self.0, self.1, PhantomData)
}
}

/// Homogeneous select. We have a vector of channels, all obeying the same
/// protocol (and in the exact same point of the protocol), wait for one of them
/// to receive. Removes the receiving channel from the vector and returns both
@@ -370,7 +395,7 @@ pub struct ChanSelect<'c, T> {
}


impl<'c, T> ChanSelect<'c, T> {
impl<'c, T: 'c> ChanSelect<'c, T> {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a warning that will become a hard error in the next stable release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

pub fn new() -> ChanSelect<'c, T> {
ChanSelect {
chans: Vec::new()
15 changes: 15 additions & 0 deletions tests/pop.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
extern crate session_types;
use session_types::*;

fn client(n: u64, mut c: Chan<(), Rec<Send<u64, Var<Z>>>>) {
let mut c = c.enter();
c = c.send(n).pop(); // type should remain the same, test will fail if it cannot compile
}

fn client2(n: u64, mut c: Chan<(), Rec<Send<u64, Rec<Send<u64, Var<S<Z>>>>>>>) {
let mut c = c.enter();
c = c.send(n).enter().send(n).pop(); // type should remain the same, test will fail if it cannot compile
}

#[test]
fn main() {}