-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .pop() to Chan as a complete alternative to .succ() and .zero(). #26
Open
ebfull
wants to merge
1
commit into
Munksgaard:master
Choose a base branch
from
ebfull:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,6 +97,23 @@ pub struct Z; | |
/// Peano numbers: Increment | ||
pub struct S<N> ( PhantomData<N> ); | ||
|
||
|
||
trait Pop<N> { | ||
type Head; | ||
type Tail; | ||
} | ||
|
||
impl<A, B> Pop<Z> for (A, B) { | ||
type Head = A; | ||
type Tail = (A, B); | ||
} | ||
|
||
impl<A, B: Pop<N>, N> Pop<S<N>> for (A, B) { | ||
type Head = B::Head; | ||
type Tail = B::Tail; | ||
} | ||
|
||
|
||
/// End of communication session (epsilon) | ||
#[allow(missing_copy_implementations)] | ||
pub struct Eps; | ||
|
@@ -312,6 +329,14 @@ impl<E, P, N> Chan<(P, E), Var<S<N>>> { | |
} | ||
} | ||
|
||
impl<E: Pop<N>, N> Chan<E, Var<N>> { | ||
/// Pop the environment, restoring the protocol N layers of recursion above us. | ||
#[must_use] | ||
pub fn pop(self) -> Chan<E::Tail, E::Head> { | ||
Chan(self.0, self.1, PhantomData) | ||
} | ||
} | ||
|
||
/// Homogeneous select. We have a vector of channels, all obeying the same | ||
/// protocol (and in the exact same point of the protocol), wait for one of them | ||
/// to receive. Removes the receiving channel from the vector and returns both | ||
|
@@ -370,7 +395,7 @@ pub struct ChanSelect<'c, T> { | |
} | ||
|
||
|
||
impl<'c, T> ChanSelect<'c, T> { | ||
impl<'c, T: 'c> ChanSelect<'c, T> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fixes a warning that will become a hard error in the next stable release. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks |
||
pub fn new() -> ChanSelect<'c, T> { | ||
ChanSelect { | ||
chans: Vec::new() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
extern crate session_types; | ||
use session_types::*; | ||
|
||
fn client(n: u64, mut c: Chan<(), Rec<Send<u64, Var<Z>>>>) { | ||
let mut c = c.enter(); | ||
c = c.send(n).pop(); // type should remain the same, test will fail if it cannot compile | ||
} | ||
|
||
fn client2(n: u64, mut c: Chan<(), Rec<Send<u64, Rec<Send<u64, Var<S<Z>>>>>>>) { | ||
let mut c = c.enter(); | ||
c = c.send(n).enter().send(n).pop(); // type should remain the same, test will fail if it cannot compile | ||
} | ||
|
||
#[test] | ||
fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How well are trait impls for tuples supported? We did this once and found out that it was a bit of an unstable feature - but that might have been at that time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's available in stable. :) Might have been an issue before the major coherence changes earlier this year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it could be done with associated types like we're using for Send, Recv, etc.?