Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: snapshot test issues #297

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Fix: snapshot test issues #297

merged 2 commits into from
Aug 16, 2021

Conversation

BatDroid
Copy link
Contributor

✅ I have read the contributing file

Summary

Fix both issues in here.

Changelog

  1. Added a mocking date solution for keeping a fixed date no matter when the date of running date is.
  2. Added a script for letting users run the tests in windows (used this solution)

Demo

I should mention the fact that I couldn't test the script since I don't have windows system.

PierreBresson
PierreBresson approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@PierreBresson PierreBresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix the carret on main. Thanks! 👍

@PierreBresson PierreBresson merged commit 84850f1 into NMF-earth:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreBresson PierreBresson PierreBresson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BatDroid @PierreBresson