Treat zero cluster UUID as non-fabric-attached #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
commented
Feb 12, 2025
pkg/nvlib/device/device.go
Outdated
| @@ -219,6 +219,9 @@ func (d *device) IsFabricAttached() (bool, error) { | |||
| if ret != nvml.SUCCESS { | |||
| return false, fmt.Errorf("error getting GPU Fabric Info: %v", ret) | |||
| } | |||
| if info.ClusterUuid == [16]uint8{} || info.CliqueId == 0 { | |||
There was a problem hiding this comment.
My one question would be whether || is the correct operator here. Is a clique ID of 0 valid if the cluster UUID is set?
There was a problem hiding this comment.
yes, clique id 0 is valid if clusterUUID is set -- in fact this is how our GH200 system has it configured
There was a problem hiding this comment.
Let's just do the following (but possibly move it lower depending on my comment below):
if info.ClusterUuid == [16]uint8{} {
klueska
reviewed
Feb 12, 2025
pkg/nvlib/device/device.go
Outdated
Comment on lines
222
to
224
| if info.ClusterUuid == [16]uint8{} || info.CliqueId == 0 { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Should this come after verifying that GPU_FABRIC_STATE_COMPLETED?
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
fix-is-fabric-attached
branch
from
fdb3f60 to
311c577
Compare
elezar
changed the title
klueska
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems which are NVLink-capable, but not attached to the fabric we see:
This change treats zero ClusterUUID values as not-attached.