Plamen5kov/refactored 5.2.361 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
1 similar comment
|
💚 |
Plamen5kov
force-pushed
the
plamen5kov/refactored_5.2.361
branch
from
92f2c50 to
ab65a4f
Compare
|
💚 |
|
Fix for setting prototypeTemplate with the wrapped function https://github.com/NativeScript/android-runtime/tree/pr/n536_Plamen5kov |
|
👍 |
Plamen5kov
force-pushed
the
plamen5kov/refactored_5.2.361
branch
from
ab65a4f to
65bca5d
Compare
|
💚 |
1 similar comment
|
💚 |
petekanev
force-pushed
the
plamen5kov/refactored_5.2.361
branch
from
4c943c0 to
854fef4
Compare
|
💔 |
|
💚 |
1 similar comment
|
💚 |
|
run ci |
|
💚 |
|
💔 |
3 similar comments
|
💔 |
|
💔 |
|
💔 |
|
💚 |
|
💔 |
|
run ci |
|
💚 |
|
💔 |
|
run ci |
|
💚 |
refactor setting of static metadata members to set fields and set methods separately set field accessors before creating the function's prototype object (we need to be sure we don't try to modify the PrototypeTemplate after the prototype object is created or it will not take effect on the created object)
… we can determine the bitness of the current process
petekanev
force-pushed
the
plamen5kov/refactored_5.2.361
branch
from
8f35536 to
f7a4144
Compare
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress:
EDIT: tests pass on:
Update v8 to version 5.2.361
Description
This PR should update the v8 to the latest stable version which supports the ES6 on 97%. See more. This will be a stepping stone for us to be able to use es6, from typescript transpiled code.
Does your commit message include the wording below to reference a specific issue in this repo?
#496
#191
Related Pull Requests
None
@NativeScript/android-runtime, please take a look at the PR