This repository was archived by the owner on Jul 21, 2021. It is now read-only.
fix(CALL_API): Use string constant instead of Symbols #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @access public | ||
| * @default | ||
| */ | ||
| const CALL_API = Symbol('Call API'); | ||
| const CALL_API = '@@redux-api-middleware/CALL_API'; |
There was a problem hiding this comment.
If found this comment where they discusses about the next branch of redux-api-middleware. They used the prefix there and it [the idea] seems to come from Redux itself.
See also https://github.com/agraboso/redux-api-middleware/blob/next/src/RSAA.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android (and other like IE, iOS <9) do not support Symbols. The polyfills and transpiling the symbols with babel do no help, so use string instead of Symbol for better support.