Revert #4595: libfetchers/tarball: Lock on effectiveUrl #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc6bfb2. Locking on the redirect destination proved to be problematic for some URLs. For example, GitHub releases downloads redirect to URLs that expire after some time, which would be broken by this behavior. Fixes NixOS#4672.
|
no longer relevant see 42f0246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #4595.
Locking on the redirect destination proved to be problematic for some
URLs. For example, GitHub releases downloads redirect to URLs that
expire after some time, which would be broken by this behavior.
Fixes #4672.
We might be able to make a new scheme e.g.
channeljust for the use case mentioned in #4595, but I feel like given the relative minor use case, it would not be worth it.