git-up: init at 1.4.0 #15751
git-up: init at 1.4.0 #15751
Conversation
FRidh
added
6.topic: python
8.has: package (new)
| meta = { | ||
| homepage = http://github.com/msiemens/PyGitUp; | ||
| description = "A git pull replacement that rebases all local branches when pulling."; | ||
| license = licenses.free; |
There was a problem hiding this comment.
The pypi page says this is covered by the MIT license.
|
Looks like this is primarily a CLI application. Makes sense to use Also, looks like the tests are not actually being run (says 0 tests run on my end). |
|
can you put colorama in a separate commit. And please prefix all python Packages with |
|
If someone has the interest in doing the requested changes for |
peterhoeg
force-pushed
the
git-up
branch
2 times, most recently
from
2123488 to
71bdbcf
Compare
|
Thanks @FRidh for splitting out the |
| sha256 = "0ydl6f4h593rd4h4xgjib7scj8jyvzq5sq6kf4145d0mcy7m5kmw"; | ||
| }; | ||
|
|
||
| buildInputs = with self; [ pytest ]; |
There was a problem hiding this comment.
does it need pytest? Looking at setup.py it uses nose for testing. Furthermore, looking at the archive it doesn't look like tests are included, in which case the tests should be disabled. When it builds it doesn't mean it is ready to be included ;-)
FRidh
removed
the
8.has: package (update)
|
@FRidh , now we're fetching directly from github.com as the pypi tarball doesn't in fact contain tests as you pointed out. |
Thanks again to @FRidh for feedback!
|
@peterhoeg note that during package building there is no network access. I don't know whether it is relevant in this case but it might be. |
|
Tested locally. |
|
@FRidh, I was building with useSandbox here, so I guess that means no
network access and everything passed.
|
|
@peterhoeg tests are now included in the archive msiemens/PyGitUp#51 (comment) |
|
And it's in #17449 |
Includes colorama upgrade 0.3.3 -> 0.3.6
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)