Overhaul copy-paste behavior #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem still occurs when screen shifted horizontally
Still crashes on copying sometimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft while I find bugs and adjust behavior.
My goal is to make the copy-paste functionality more useful for copying lanes, while keeping the original behavior for floating objects.
I rewrote the entire
DefaultFumenEditorClipboard.Changes
Nextnodes selectedCoordinate changes
Copy-paste code is easier to work with.
Also allows for pasting objects after changing editor vertical scale.
OngekiFumenEditor_7SHdbVzm3Y.mp4
Partial lane copying
Lanes can be copied without having to select the start node.
Lane generation on dockables
If a dockable object is selected and is outside of the bounds of selected lane nodes, start/next node(s) will automatically be created in the clipboard. The original lanes are not modified at all.
Examples (left is selection, right is result of paste)
Hold copying
Holds with a selected HoldEnd will copy the HoldEnd into the clipboard. If only the HoldEnd is is selected, it will be ignored when copying.
Examples (left is selection, right is result of paste)
