feat: Add mode support and customizeable modes trying to get to the ability to customize modes #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
Viewers
|
||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/mode-support
|
| Run status |
|
| Run duration | 02m 13s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
42
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/volume/MPR.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF MPR > should correctly render Crosshairs for MPR |
Test Replay
Screenshots
Video
|
|
wayfarer3130
commented
Mar 20, 2025
There was a problem hiding this comment.
@pedrokohler - add this file to your PR, and add the toolbar button and toolbar section to this file.
wayfarer3130
commented
Mar 20, 2025
| 'UltrasoundDirectionalTool', | ||
| 'WindowLevelRegion', | ||
| ]); | ||
| toolbarService.addButtons(getCustomization('toolbarButtons')); |
There was a problem hiding this comment.
@pedrokohler - to customize the toolbar, you will also need these two lines, and to create a new custom section that extends the default tools/buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR starts allowing modes to be customized with the customization framework.
The idea is that a common set of definitions can be defined within the extensions, and then used to register the mode in a way that allows specific changes to be made to the underlying registration/setup.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment