fix: Delete study measurements instead of all measurements #4882
+237
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/delete-filtered-measurements
|
| Run status |
|
| Run duration | 02m 15s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
wayfarer3130
commented
Mar 24, 2025
| @@ -26,13 +28,19 @@ export const groupByStudy = (items, grouping, childProps) => { | |||
| const studyUID = getItemStudyInstanceUID(item); | |||
| if (!groups.has(studyUID)) { | |||
| const items = []; | |||
| const filter = MeasurementFilters.filterAnd( | |||
There was a problem hiding this comment.
The study measurements filter needs to define the filter object so that saving and other operations apply on a per study basis.
wayfarer3130
commented
Mar 24, 2025
| <Cross2Icon className="text-primary h-4 w-4" /> | ||
| <span className="sr-only">Close</span> | ||
| </DialogPrimitive.Close> | ||
| {!unstyled && ( |
There was a problem hiding this comment.
The unstyled dialogs should not show the close icon.
wayfarer3130
commented
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For multiple study measurements, the delete function was deleting all measurements, not just the single study measurements.
Changes & Results
Create a filter argument to delete just the specified measurements (also applies to save/load etc)
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment