feat(segmentation): Enhance Segmentation with New AI and Once Click Tools #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggleUseCenterSegmentIndex command in cornerstone extension
- Added support for 'CircularBrushForAutoSegmentAI' in segmentation tool groups. - Updated commandsModule to accept and reject previews for active labelmap tools, integrating segmentAI functionality. - Modified ViewerLayout to include refs for left and right panels, improving mouse interaction handling. - Adjusted webpack configuration for output directory structure.
- Renamed `setSourceViewportForReferenceLinesTool` to `setViewportForToolConfiguration` for clarity and added `toolName` parameter. - Introduced `_handlePreviewAction` to streamline accept/reject preview actions for labelmap tools. - Added new commands for `interpolateScrollForMarkerLabelmap` and `clearMarkersForMarkerLabelmap`. - Integrated `LabelmapSlicePropagationTool` and `MarkerLabelmapTool` into the toolbar and tool groups. - Updated hotkey bindings to include new commands for marker labelmap functionalities. - Improved UI elements in the Toolbox for better user experience.
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/new-seg-tools-ai
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances segmentation functionality and updates dependencies while adding several new segmentation-related tools and UI improvements. Key changes include:
- Dependency upgrades for @cornerstonejs packages to version ^3.8.2.
- New segmentation tools and commands for improved segmentation and labelmap assist.
- UI adjustments in toolbar and viewer layouts to support new functionality.
Reviewed Changes
Copilot reviewed 21 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| platform/app/.webpack/webpack.pwa.js | Added copy rule for onnxruntime-web assets. |
| modes/segmentation/src/toolbarButtons.ts | Added new segmentation toolbar buttons and updated callbacks. |
| modes/segmentation/src/initToolGroups.ts | Included new segmentation tool groups. |
| modes/segmentation/src/index.tsx | Updated button sections to include new segmentation options. |
| modes/basic-test-mode/src/toolbarButtons.ts | Replaced outdated command for reference lines tool. |
| extensions/default/src/utils/Toolbox.tsx | Made minor styling adjustments. |
| extensions/default/src/ViewerLayout/index.tsx | Added panel refs and blur handler on mouse enter. |
| extensions/default/src/Toolbar/ToolBoxWrapper.tsx | Updated component props to include additional className. |
| extensions/cornerstone/src/services/SegmentationService/SegmentationService.ts | Commented out volume referencing in segmentation service. |
| extensions/cornerstone/src/initCornerstoneTools.js | Imported and registered new segmentation tools. |
| extensions/cornerstone/src/customizations/segmentationPanelCustomization.tsx | Added a new switch for center-based segment index and modified label texts. |
| extensions/cornerstone/src/commandsModule.ts | Introduced new ONNX segmentation commands and updated viewport configuration command. |
| extensions/cornerstone-dicom-seg/src/getToolbarModule.ts | Minor update to toolbar module configuration. |
Files not reviewed (7)
- extensions/cornerstone-dicom-pmap/package.json: Language not supported
- extensions/cornerstone-dicom-seg/package.json: Language not supported
- extensions/cornerstone-dicom-sr/package.json: Language not supported
- extensions/cornerstone-dynamic-volume/package.json: Language not supported
- extensions/cornerstone/package.json: Language not supported
- extensions/measurement-tracking/package.json: Language not supported
- platform/app/package.json: Language not supported
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4513
fixes #4512
This pull request includes a variety of updates across several files, primarily focused on updating dependencies, adding new tools, and improving the segmentation functionality. The most important changes are grouped by theme below:
Dependency Updates:
@cornerstonejs/adapters,@cornerstonejs/core, and other@cornerstonejsdependencies to version^3.8.2in multiplepackage.jsonfiles. [1] [2] [3] [4] [5] [6]Segmentation Enhancements:
ONNXSegmentationControllerimport and initializedsegmentAIwith new models incommandsModule.ts. [1] [2]toggleUseCenterSegmentIndex,clearMarkersForMarkerLabelmap, andtoggleLabelmapAssist. [1] [2]Use Center as Segment Index. [1] [2] [3]Tool Additions:
LabelmapSlicePropagationTool,MarkerLabelmapTool, andRegionSegmentPlusToolininitCornerstoneTools.js. [1] [2] [3]UI Improvements:
leftPanelRefandrightPanelRefto handle mouse enter events inViewerLayoutto ensure the active element is blurred when necessary. [1] [2] [3] [4] [5]These changes collectively enhance the functionality and usability of the application, especially in terms of segmentation capabilities and user interface interactions.