Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute dask array before np array equal [all tests ci] #1452

Merged

Conversation

ctuguinay
Copy link
Collaborator

Resolves:

Warning: The numpy.array_equal function is not implemented by Dask array. You may want to use the da.map_blocks function or something similar to silence this warning. Your code may stop working in a future release.

which was discovered in #1444.

@ctuguinay ctuguinay self-assigned this Feb 16, 2025
@ctuguinay ctuguinay added the bug Something isn't working label Feb 16, 2025
@ctuguinay ctuguinay modified the milestones: v0.9.2, v0.9.1 Feb 16, 2025
@ctuguinay ctuguinay marked this pull request as draft February 17, 2025 17:28
@ctuguinay ctuguinay changed the title Compute dask array before np array equal Compute dask array before np array equal [all tests ci] Feb 17, 2025
@ctuguinay ctuguinay closed this Feb 17, 2025
@ctuguinay ctuguinay reopened this Feb 17, 2025
@ctuguinay ctuguinay closed this Feb 17, 2025
@ctuguinay ctuguinay reopened this Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (9f56124) to head (058882e).
Report is 179 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
+ Coverage   83.52%   85.22%   +1.69%     
==========================================
  Files          64       72       +8     
  Lines        5686     6590     +904     
==========================================
+ Hits         4749     5616     +867     
- Misses        937      974      +37     
Flag Coverage Δ
unittests 85.22% <ø> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay marked this pull request as ready for review February 17, 2025 18:45
@ctuguinay ctuguinay requested a review from leewujung February 17, 2025 18:45
@ctuguinay
Copy link
Collaborator Author

@leewujung This one should be ready for review

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, makes sense. Thanks! Merging now.

@leewujung leewujung modified the milestones: v0.9.1, v0.10.0 Feb 18, 2025
@leewujung leewujung merged commit 7ac1185 into OSOceanAcoustics:main Feb 18, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants