Lint the whole codebase and add coverage test. #317
Conversation
* add function to correct ping_time reversal * add ping time reversal detection function * add quick function for checking reversed timestamps * change coerce function to handle arbitrary coordinate name
lsetiawan
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #317 +/- ##
=====================================
Coverage ? 1.69%
=====================================
Files ? 35
Lines ? 3008
Branches ? 0
=====================================
Hits ? 51
Misses ? 2957
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@leewujung This is all ready to go with all the latest changes for QC and Imran's ADCP Time Encoding issue fixes, linted. 😄 |
|
Let me know when this is good to merge. I'll need to merge it so that I can clean up the commit message a little bit, since it's currently very messy. Thanks! |
echopype/calibrate/calibrate_azfp.py
Outdated
| a = self.cal_params[ | ||
| "DS" | ||
| ] # scaling factor (slope) in Fig.G-1, units Volts/dB], see p.84 |
There was a problem hiding this comment.
Not very readable, would be better to move the comment on top of the line and retain the code in one line
There was a problem hiding this comment.
@lsetiawan Thanks for the linting effort!
I went through all changes quickly with a spirit of spotting anomalies, and found a few things that I commented on. Let me know what you think. Otherwise I think this is ready to be merged.
This PR cleans up code formatting and styling to meet pep8 coding conventions. Additionally, code coverage tests are added. Also, the setup configurations are now mostly in
setup.cfgrather thansetup.py.Note: This PR is not ready for review or merging as of 4/30/2021.Update: This PR is now ready for review and the lint tests are now passing.