Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for optional kwargs for loading group #456

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

lsetiawan
Copy link
Member

Overview

This PR allows for being able to pass in additional xr.open_dataset arguments to open_converted for example adding chunks='auto' will delay the arrays in each group so that one can combine without blowing up memory.

Additionally, there's a fix to the datatype of src_filenames, ensuring that they're always a string.

@lsetiawan lsetiawan changed the title Allow for optional kwargs for loading Allow for optional kwargs for loading group Oct 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #456 (02f5239) into dev (900f4bc) will decrease coverage by 3.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #456      +/-   ##
==========================================
- Coverage   76.77%   73.74%   -3.04%     
==========================================
  Files          38       11      -27     
  Lines        3324      697    -2627     
==========================================
- Hits         2552      514    -2038     
+ Misses        772      183     -589     
Flag Coverage Δ
unittests 73.74% <83.33%> (-3.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/echodata/api.py 16.66% <ø> (-66.67%) ⬇️
echopype/calibrate/calibrate_ek.py 89.88% <66.66%> (-0.67%) ⬇️
echopype/echodata/combine.py 60.68% <100.00%> (-10.01%) ⬇️
echopype/echodata/echodata.py 58.82% <100.00%> (-28.87%) ⬇️
echopype/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
echopype/echodata/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
echopype/echodata/convention/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900f4bc...02f5239. Read the comment docs.

@lsetiawan lsetiawan merged commit 4127af3 into OSOceanAcoustics:dev Oct 21, 2021
@lsetiawan lsetiawan deleted the fix_combine branch October 21, 2021 23:09
@leewujung leewujung added this to the 0.5.5 release milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants