Some fixes and improvement #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikhailk-2012
commented
Feb 16, 2022
mikhailk-2012
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| Doc update? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #... |
Rotzbua
reviewed
Oct 19, 2022
| @@ -136,7 +136,7 @@ class MFRC522 { | |||
| ///////////////////////////////////////////////////////////////////////////////////// | |||
| // Functions for manipulating the MFRC522 | |||
| ///////////////////////////////////////////////////////////////////////////////////// | |||
| bool PCD_Init(); | |||
| bool PCD_Init(bool antenna_on = true); | |||
There was a problem hiding this comment.
What is the use case for this?
Why not a simple PCD_AntennaOff(); after PCD_Init()?
| @@ -1,6 +1,9 @@ | |||
| /* SPDX-License-Identifier: LGPL-2.1 */ | |||
| #include "MFRC522v2.h" | |||
|
|
|||
| // On 32-bit processors, software CRC computation is more efficient than | |||
There was a problem hiding this comment.
Can you provide some numbers? For me it seems just additional code to maintain and source of error.
|
Do you need more testing on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.