Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Project page sorting #73

Closed
arkid15r opened this issue Nov 9, 2024 · 11 comments · Fixed by #552 or #608
Closed

Implement Project page sorting #73

arkid15r opened this issue Nov 9, 2024 · 11 comments · Fixed by #552 or #608

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Nov 9, 2024

For the new frontend add ability to sort projects by starts/contributors/forks/other metadata attributes.

Based on the user's feedback:

and also to sort by the number of contributors/stars

@tsu-ki
Copy link
Contributor

tsu-ki commented Nov 10, 2024

/assign

Copy link
Contributor

tsu-ki commented Nov 10, 2024

can you please elaborate on what needs to be done here?
I apologise if this seems like a menial task but since it's my first issue, I want to be sure that I know correctly what I'm working with here.

@arkid15r
Copy link
Collaborator Author

This one may be not that easy. It requires both backend and frontend logic implementation. It seems the backend part will require additional index setup:

I didn't add any details and was going to work on it myself. But if you feel it's something that you can handle let do that -- I'd be happy to guide you and help with any questions.

@tsu-ki let me know what you think and I'll try to come up w/ more detailed description.

@tsu-ki
Copy link
Contributor

tsu-ki commented Nov 11, 2024

sure, i'll quickly go through the code and the guide you've shared. thank you for helping me out

@arkid15r
Copy link
Collaborator Author

Hey @tsu-ki any progress on this? Feel free to reach out to me here or in our Slack channel (DMs work too) in case you need help with this one.

@arkid15r
Copy link
Collaborator Author

re-assigning after discussing it in Slack

@Rajgupta36
Copy link
Collaborator

@arkid15r , i can implement it in frontend.

@arkid15r
Copy link
Collaborator Author

@arkid15r , i can implement it in frontend.

Please read this comment. We use index engine to produce relevant search results so I doubt I can be done on the frontend.

@Rajgupta36
Copy link
Collaborator

@arkid15r , i can implement it in frontend.

Please read this comment. We use index engine to produce relevant search results so I doubt I can be done on the frontend.

Yes, after getting the results, we can sort them on the frontend. It's quite easy compared to making changes in the API call.

@arkid15r
Copy link
Collaborator Author

My point is that search/ranking/sorting can be done on the index engine side only so the frontend sorting would be limited to one page only that doesn't add a lot of value.
Let me know if I'm missing something

@Rajgupta36
Copy link
Collaborator

You're right. Frontend sorting is limited to one page and isn't good for large datasets. However, we could use frontend sorting for single pages to ensure better user experience and reduce API calls, while relying on backend sorting to handle larger datasets across pages. what're your thoughts on this approach!

@arkid15r arkid15r assigned arkid15r and unassigned arkid15r Dec 15, 2024
@arkid15r arkid15r moved this to Backlog in Project Nest Dec 16, 2024
@arkid15r arkid15r added this to the Enhanced search 🔍 milestone Dec 29, 2024
@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Dec 30, 2024
@arkid15r arkid15r assigned Rajgupta36 and unassigned arkid15r Dec 30, 2024
@arkid15r arkid15r moved this from Todo to In progress in Project Nest Dec 30, 2024
@arkid15r arkid15r moved this from In progress to Backlog in Project Nest Dec 30, 2024
@arkid15r arkid15r moved this from Backlog to In progress in Project Nest Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment