Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROS Melodic/Dashing buildfarm failures #269

Merged

Conversation

wxmerkt
Copy link
Member

@wxmerkt wxmerkt commented Nov 27, 2019

octovis is currently failing on the ROS Melodic and Dashing buildfarms because my previous PR accidentally omitted a required dependency (and that the fallback builds libqlviewer-qt4 in the source tree).

This PR:

  • Fixes the missing dependency in octovis' package.xml (and also changes the style back to build and exec dependencies)
  • Also changes the generation of CMake config files etc. to happen in the binary dir instead of in the source directory. This is required on read-only filesystems
  • Adds the public link attribute for octovis

@ahornung, could you please make a patch release 1.9.2 after this PR? Thank you :-)

@ahornung
Copy link
Member

Also changes the generation of CMake config files etc. to happen in the binary dir instead of in the source directory. This is required on read-only filesystems

Is this necessary for the build farm? If not I would treat it separately for a 1.10 release. It changes the output directory of the compiled binaries (source target).

When cloning your branch locally and compiling the complete distribution, octovis fails to link for me (cannot find liboctomap.so). No idea why it didn't occur on Travis, though.

@wxmerkt
Copy link
Member Author

wxmerkt commented Nov 28, 2019

I will split the PR then. I am using ROS Industrial CI locally to run on a clean Docker. There it linked successfully - and mounts the source directory read-only which is why it's required.

However, neither the master branch prior to the changes nor this one finds the libqqglviewer library at runtime. There werent any linking errors.

- Forgot libqlviewer-qt4-dev as a dependency which caused Melodic builds to fail
- This now uses build_depend/exec_depend as previously again
- Tested with ROS Industrial CI
@wxmerkt wxmerkt force-pushed the wxm-fix-melodic-buildsystem-failures branch from 649894d to 9bc78fc Compare November 28, 2019 19:05
@wxmerkt
Copy link
Member Author

wxmerkt commented Nov 28, 2019

I've reduced this PR to only include the changes to package.xml and split out the other two commits. It doesn't work with ROS Industrial CI now, but should fix the ROS buildfarm failures.

@ahornung ahornung merged commit b67b2c5 into OctoMap:devel Nov 28, 2019
@ahornung
Copy link
Member

Thanks! That should do the trick to move forward, we can then tackle the read-only FS issues separately. I just released v1.9.2.

We should probably get rid of the Qt4 dependency sometime soon, and switch to Qt5 completely for octovis.

@wxmerkt
Copy link
Member Author

wxmerkt commented Nov 29, 2019

Thank you very much @ahornung. I will make the ROS releases to fix the buildfarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants