add support for arweave transactions #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bit of a mess remove unused code
tzarebczan
reviewed
Feb 28, 2025
| if err != nil { | ||
| return nil, errors.Err(err) | ||
| } | ||
| if response.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
Probably want to let through network errors/internal apis hiccups. Only hard fail on real missing tip
tzarebczan
reviewed
Feb 28, 2025
| } | ||
| cents = lbc.ToUnit(btcutil.AmountSatoshi) | ||
| } else if args.PaymentIntentID != nil { | ||
| cents *= 100 |
There was a problem hiding this comment.
what's this do? If it's dryrun, we shouldn't see a txids/payment intents. hmm
nikooo777
force-pushed
the
arweave-tx-support
branch
from
91f36b9 to
b7268ec
Compare
nikooo777
force-pushed
the
arweave-tx-support
branch
from
b7268ec to
cc556af
Compare
remove old code stop returning signatures populate more fields in the db for paid txs
nikooo777
force-pushed
the
arweave-tx-support
branch
from
5dfbd31 to
233ff19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bit of a mess
remove unused code