Handle missing security schemes component #211
Merged
+236
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into a
NullPointerException
that I did not expect when diffing two specifications.Turned out my specification was missing
components.securitySchemes
because it was using a custom extension, but the error was not really expected or informative.This pull request:
IllegalArgumentException
ifcomponents.securitySchemes
is missing,security_diff_4.yaml
which is copied fromsecurity_diff_3.yaml
but removescomponents.securitySchemes
,IllegalArgumentException
(instead ofNullPointerException
) -- this test fails without the patch.Note: this PR continues to assume that missing
components.securitySchemes
is problematic (i.e., I will need to update my specification file that started this).cc @joschi