Fix NPE with unnamed schemas in {one,any,all}-of
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsdatta
commented
Mar 23, 2021
Comment on lines
+98
to
+100
| result.putAll(getUnnamedSchemas(composedSchema.getAllOf(), "all-of")); | ||
| result.putAll(getUnnamedSchemas(composedSchema.getOneOf(), "one-of")); | ||
| result.putAll(getUnnamedSchemas(composedSchema.getAnyOf(), "any-of")); |
There was a problem hiding this comment.
quick and dirty workaround - naming the unnamed schemas in order of their appearance in the list.
Comment on lines
+132
to
+134
| if (schemas == null) { | ||
| return result; | ||
| } |
There was a problem hiding this comment.
list is sometimes null (in the diff case) which throws nullptr
|
@joschi another fix! this has been throwing a ton of null pointers for us in production so thought I'd put in a quick fix. Would love a review/release! |
|
Hey @joschi! Any chance we could get a review+release of this? It's been pretty noisy in our diffs, would like to avoid forking if possible 😢 |
joschi
changed the title
{one,any,all}-of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176