Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --header parameter #236

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix --header parameter #236

merged 1 commit into from
May 26, 2021

Conversation

derjust
Copy link
Contributor

@derjust derjust commented May 26, 2021

The --header CLI parameter is registered as option but never actually
passed onto the OpenApiCompare.

This fixes #234

The `--header` CLI parameter is registered as option but never actually
passed onto the `OpenApiCompare`.

This fixes OpenAPITools#234
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derjust LGTM. Thanks a lot!

@joschi joschi added the bug label May 26, 2021
@joschi joschi added this to the Release 2.0.0 milestone May 26, 2021
@joschi joschi changed the title Actually use header parameter Fix --header parameter May 26, 2021
@joschi joschi merged commit d372d5f into OpenAPITools:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--header parameter is ignored
2 participants