Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change packaging to maven-plugin #287

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

kubamarchwicki
Copy link
Contributor

@kubamarchwicki kubamarchwicki commented Nov 16, 2021

Maven plugin descriptor is not getting correctly generated, therefore example usage of openapi-diff with maven fails.
Changing the packaging fixes the issue.

Additional maven-example (a plugin verification) is also provided within this PR

@kubamarchwicki
Copy link
Contributor Author

It ain't obvious to provide a test case to cover the change but I've added a minimal maven-plugin example which fails with the current setup: https://github.com/OpenAPITools/openapi-diff/compare/master...kubamarchwicki:maven-plugin-example?expand=1

If you feel it's relevant to the project, I'm happy to contribute it in a separate PR.

@joschi
Copy link
Contributor

joschi commented Nov 16, 2021

@kubamarchwicki Thanks a lot for your contribution!

I think the reproducer you've linked to would also be useful to avoid regressions. 😄

Do you want to add it in this pull request or create a new one?

@joschi joschi added the bug label Nov 16, 2021
@joschi joschi added this to the 2.0.0 milestone Nov 16, 2021
@kubamarchwicki
Copy link
Contributor Author

Do you want to add it in this pull request or create a new one?

I've added to this PR. I've linked reproducer separately as I wasn't sure if you want it in the main project :)

@joschi joschi merged commit bf26b65 into OpenAPITools:master Nov 16, 2021
@kubamarchwicki kubamarchwicki deleted the fix-mvn-plugin branch November 16, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants