Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker release action with multi-platform #336

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

kaschula
Copy link
Contributor

Update the docker/build-push-action@v2 to include the platforms: linux/amd64,linux/arm64 argument. This will ensure the Docker release step builds for the arm64 as well as amd64 platforms.

Update the docker/build-push-action@v2 to include the `platforms: linux/amd64,linux/arm64` argument. This will ensure the Docker release step builds for the arm64 as well as amd64 platforms.
@joschi
Copy link
Contributor

joschi commented Feb 25, 2022

@kaschula Thanks for your contribution!

Would we have to update anything in the Dockerfile, e. g. the base images or something else so that it the resulting container image actually works on ARM64?

https://github.com/OpenAPITools/openapi-diff/blob/4d755a6aa22f06936bad7b1a8fdaa07182976632/Dockerfile

@kaschula
Copy link
Contributor Author

Hi @joschi ,

Looking at this https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ there is guide for updating the Dockerfiles to cope with different architecture builds. I can't see if this is necessary though or if it is just done for efficiency. I will need some time to look into it. Thanks

@eth0net
Copy link

eth0net commented Feb 28, 2022

As long as the base image is available in ARM64, which it is, this should work fine. It built and ran successfully in ARM64 during local testing on an M1 MacBook Pro using the ARM version of docker.

See the base image support here and here.

@joschi joschi added this to the 2.1.0 milestone Feb 28, 2022
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaschula @eth0net Thanks for your feedback! I'll merge this PR then. 😄

@joschi joschi merged commit b424f21 into OpenAPITools:master Feb 28, 2022
joschi pushed a commit that referenced this pull request Jul 7, 2022
The `linux/arm64` architecture is not an available platform without first enabling docker QEMU.

Refs #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants