Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to run
openapi-diff
inside a Docker container.I had to adjust the pom.xml file because the
jar-with-dependencies
archive wasn't being generated onmvn package
and with the other jar files I was getting theno main manifest attribute, in "xxxx.jar
error.How it works?
pom.xml
file in order to use the properjar
.Now the missing part is publishing/pushing the image to Docker Hub. I guess you'll want to do that under your own account.
After that the "Build image" part won't be required anymore (as described in the readme changes I added) for the end users.
The nice thing is that once you create the project on Docker hub and configure it, you can have automated builds on every new (tag) release:
https://docs.docker.com/docker-hub/builds/
If you need any help on that just let me know.