bugfix (to master): after openapi specs comparison, all parameters are removed #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om new spec (right side) because of reused parameters list. - updated code to use copy of given parameters list in diff method - added few tests to cover this case
|
|
…lt should yield not issues.
|
joschi I found a bug where after comparison request parameters are removed from "new spec" OpenAPI object, because in the |
…d_from_new_spec Conflicts: core/src/main/java/org/openapitools/openapidiff/core/compare/ParametersDiff.java
joschi
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: after openapi specs comparison, all parameters are removed from new spec (right side) because of reused parameters list.
diffmethod. Root cause (before fix)openapi-diff/core/src/main/java/org/openapitools/openapidiff/core/compare/ParametersDiff.java
Line 66 in f595a84
Issue affects
2.0.xandmasterbranches.Ports
2.0.x: bugfix (to 2.0.x): after openapi specs comparison, all parameters are removed #453master: bugfix (to master): after openapi specs comparison, all parameters are removed #454