Add file output parameters to Maven plugin #502
Merged
+282
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joschi thank you for all the work you put into this. We would need the the same file output functionnality as in the CLI but in the maven plugin as proposed in #501. However, we are working woth a private bitbucket and a fork is not the best solution for us since we want to be able to sync with the latest. That is why I propose the changes, hoping that these will be available publicly and allow us to use the original plugin in our code. Let me know if you have any suggestions or comments. Thanx |
joschi
changed the title
Conflicts: maven/src/main/java/org/openapitools/openapidiff/maven/OpenApiDiffMojo.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests added yet.
Will change the file handling to prevent overwritting existing files (like system files :) ). This handling will be extracted in its own class.
Will add filename string sanitization and related tests.
Closes #501