Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve allOf merging for composite schemas #85

Merged
merged 2 commits into from
Jan 8, 2020
Merged

improve allOf merging for composite schemas #85

merged 2 commits into from
Jan 8, 2020

Conversation

damianw
Copy link
Contributor

@damianw damianw commented May 31, 2019

Using allOf left some holes in the diffing - this PR merges the rest of the schema together and adds a test which changes the type of a merged schema.

@quen2404
Copy link
Member

quen2404 commented Jan 8, 2020

Thank you for your work @damianw !

@quen2404 quen2404 merged commit 582674d into OpenAPITools:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quen2404 quen2404 quen2404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damianw @quen2404