Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript-Angular] add nullable support #1730

Merged
merged 6 commits into from
Dec 22, 2018

Conversation

smasala
Copy link
Contributor

@smasala smasala commented Dec 21, 2018

PR checklist

  • Read the contribution guidelines.
  • x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Support v3 spec config nullable so that --strictNullChecks can be used with Typescript

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @wing328

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 4.0.0 milestone Dec 22, 2018
@wing328 wing328 merged commit 43abd61 into OpenAPITools:master Dec 22, 2018
@wing328 wing328 changed the title Typescript nullable [Typescript-Angular] add nullable support Dec 30, 2018
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@smasala thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

@smasala
Copy link
Contributor Author

smasala commented Jan 14, 2019

@wing328 the docker hub image for v4.0.0-beta doesn't seem to have this fix but the latest version does.

Ps. Thanks for the merge and a Happy New Year to you too ;)

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* fix name sanitation when using kebab case filenaming

* remove whitespaces

* nullable

* remove test comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants