-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in case of defined status codes > 299 switch will have no effect #19483
Conversation
…described in issue 7788 so we get only an error if statusCode is not defined AND not between 200 and 299 #7788
have i anything todo for implement into the master branch or wil it implemented with next version? |
@kruegge82 thanks for the PR please follow step 3 to update the samples so that CI can verify the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure which step 3? i have not change files after PR...
…described in issue 7788 so we get only an error if statusCode is not defined AND not between 200 and 299 #7788
up to date
cc |
have i anything more todo? |
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12) @deluxetom i have anything more todo? i ask because the PR is not merged with master branch... |
tested the change locally and looks good. thanks for the PR sorry for the delay as we're short-handed in reviewing PRs from the community |
…described in issue 7788
so we get only an error if statusCode is not defined AND not between 200 and 299
#7788
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)