Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP status code in the setExampleResponse #19501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renuka-fernando
Copy link

Description

Enable returnSuccessCode via maven plugin. Generate Spring Boot app (<generatorName>spring</generatorName>) via maven plugin.

<returnSuccessCode>true</returnSuccessCode>

Open API Generator version: 7.8.0

Please find the issue details in the issue: #19446

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@renuka-fernando renuka-fernando changed the title Spring status code Add HTTP status code in the setExampleResponse Aug 31, 2024
@renuka-fernando
Copy link
Author

hi @cachescrubber @welshm @MelleD,

Could you please review the PR?

@renuka-fernando
Copy link
Author

renuka-fernando commented Sep 13, 2024

Thanks @martin-mfg

hi @atextor, @manedev79 ,@javisst, @borsch

Could you please review?

@renuka-fernando
Copy link
Author

renuka-fernando commented Oct 5, 2024

Hi @wing328, @4brunu, @macjohnny,

Could you please advise me on how I can get this merged?

Thanks

@macjohnny
Copy link
Member

Hi @wing328, @4brunu, @macjohnny,

Could you please advise me on how I can get this merge?

Thanks

usually the technical committee that you added in the PR description will have a look at some point. sometimes a reminder can help

@renuka-fernando
Copy link
Author

hi @cachescrubber @welshm @MelleD,

Kind reminder.

Thanks

1 similar comment
@renuka-fernando
Copy link
Author

hi @cachescrubber @welshm @MelleD,

Kind reminder.

Thanks

@martin-mfg
Copy link
Contributor

Hi @renuka-fernando, is there a reason why you're looking for a review specifically from @cachescrubber, @welshm and @MelleD? The general recommendation is just to get a review from any member of the relevant technical commitee. Which in this case you got already from me. ;) So I think the next step is to have this PR merged by a project maintainer.

@renuka-fernando
Copy link
Author

hi @martin-mfg nope. my bad. shall we merge then :)

@martin-mfg
Copy link
Contributor

Yes, let's wait for @wing328 to merge this PR.

@renuka-fernando
Copy link
Author

Yes, let's wait for @wing328 to merge this PR.

Sure, Thanks :)

@wing328
Copy link
Member

wing328 commented Dec 15, 2024

@renuka-fernando thanks for the PR but it's hard to review as there's no change in sample.

if you can use a public repo (e.g. petstore) and with a commit showing the difference in the output (code) with and without and option, that will make the review a lot easier.

Or something like #20098 (comment) to show the diff

@renuka-fernando
Copy link
Author

@renuka-fernando thanks for the PR but it's hard to review as there's no change in sample.

if you can use a public repo (e.g. petstore) and with a commit showing the difference in the output (code) with and without and option, that will make the review a lot easier.

Or something like #20098 (comment) to show the diff

Hi @wing328,

Sorry for the delayed response. I just whether we can update it in the existing samples. But it requires to add returnSuccessCode=true. I guess you meant to show the diff with an external commit in my own repo right? Sure I will provide it.

renuka-fernando added a commit to renuka-fernando/openapi-generator-spring-boot-sample-petstore that referenced this pull request Feb 17, 2025
@renuka-fernando
Copy link
Author

@renuka-fernando
Copy link
Author

Hi @wing328

Kind Reminder

1 similar comment
@renuka-fernando
Copy link
Author

Hi @wing328

Kind Reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants