-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP status code in the setExampleResponse #19501
base: master
Are you sure you want to change the base?
Add HTTP status code in the setExampleResponse #19501
Conversation
832aa79
to
4ab15bd
Compare
4ab15bd
to
0897a4f
Compare
hi @cachescrubber @welshm @MelleD, Could you please review the PR? |
Thanks @martin-mfg hi @atextor, @manedev79 ,@javisst, @borsch Could you please review? |
Hi @wing328, @4brunu, @macjohnny, Could you please advise me on how I can get this merged? Thanks |
usually the technical committee that you added in the PR description will have a look at some point. sometimes a reminder can help |
hi @cachescrubber @welshm @MelleD, Kind reminder. Thanks |
1 similar comment
hi @cachescrubber @welshm @MelleD, Kind reminder. Thanks |
Hi @renuka-fernando, is there a reason why you're looking for a review specifically from @cachescrubber, @welshm and @MelleD? The general recommendation is just to get a review from any member of the relevant technical commitee. Which in this case you got already from me. ;) So I think the next step is to have this PR merged by a project maintainer. |
hi @martin-mfg nope. my bad. shall we merge then :) |
Yes, let's wait for @wing328 to merge this PR. |
Sure, Thanks :) |
@renuka-fernando thanks for the PR but it's hard to review as there's no change in sample. if you can use a public repo (e.g. petstore) and with a commit showing the difference in the output (code) with and without and option, that will make the review a lot easier. Or something like #20098 (comment) to show the diff |
Hi @wing328, Sorry for the delayed response. I just whether we can update it in the existing samples. But it requires to add |
Hi @wing328 Please find the diff: renuka-fernando/openapi-generator-spring-boot-sample-petstore@efaae92 |
Hi @wing328 Kind Reminder |
1 similar comment
Hi @wing328 Kind Reminder |
Description
Enable
returnSuccessCode
via maven plugin. Generate Spring Boot app (<generatorName>spring</generatorName>
) via maven plugin.Open API Generator version: 7.8.0
Please find the issue details in the issue: #19446
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)cc: @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)