-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elixir] Update Tesla dependency to version 1.0 #2326
[Elixir] Update Tesla dependency to version 1.0 #2326
Conversation
@yknx4 thanks for the PR but Shippable CI reports the following errors:
Ref: https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/6398/1/console Please take a look and let us know if you need any help. |
@wing328 All issues have been addressed :) |
5293cd1
to
8d94c35
Compare
…ode to arbitrary struct
8d94c35
to
95d8d5c
Compare
Hey @yknx4, first of all, thank you very much for your PR Your changes look pretty good to me, there's only one thing I noticed: The new tesla 1.0 will return a tuple ( This could be fixes by
Please let me know if I can assist you somehow according to this PR and again, thank you very much for your contribution |
@mrmstn Thank you very much for your feedback, I'll follow the second approach you propose. |
modules/openapi-generator/src/main/resources/elixir/request_builder.ex.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/elixir/request_builder.ex.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/elixir/request_builder.ex.mustache
Show resolved
Hide resolved
…ilder.ex.mustache Co-Authored-By: yknx4 <[email protected]>
…ilder.ex.mustache Co-Authored-By: yknx4 <[email protected]>
If no further feedback on this PR, I'll merge it tomorrow (Wed) |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
,./bin/security/{LANG}-petstore.sh
and./bin/openapi3/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.Description of the PR
Replace Poison with Jason (it is the new default JSON encoder)(Jason doesn't support
:as
option)closes #2325
cc @mrmstn