Skip to content

electrical energy share #1434 #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 25, 2023
Merged

electrical energy share #1434 #1561

merged 20 commits into from
May 25, 2023
+54 −5

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented May 25, 2023 •
edited
Loading

Summary of the discussion

Introduce electrical energy share (degree of electrification) and the respective quantity value and harmonize with RE-share.

Type of change (CHANGELOG.md)

Added

Updated

Workflow checklist

Automation

Closes #1434

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Sorry, something went wrong.

@stap-m stap-m self-assigned this May 25, 2023
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label May 25, 2023
@stap-m stap-m marked this pull request as ready for review May 25, 2023 13:11
@stap-m stap-m requested review from l-emele, u-mueller, chrwm and Ludee May 25, 2023 13:11
l-emele
l-emele requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with other abbreviations, I think we should use renewable energy share and renewable energy share value as labels and RE-share and RE-share value as alternative terms.

stap-m
stap-m commented May 25, 2023
View reviewed changes
@stap-m stap-m requested a review from l-emele May 25, 2023 15:11
stap-m
stap-m commented May 25, 2023
View reviewed changes
l-emele
l-emele reviewed May 25, 2023
View reviewed changes
l-emele
l-emele reviewed May 25, 2023
View reviewed changes
l-emele
l-emele approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two further suggestions, but I approve now.

@stap-m stap-m merged commit 460527e into dev May 25, 2023
@stap-m stap-m deleted the feature-1434-share-of-electrification branch October 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-emele l-emele

@u-mueller u-mueller

@chrwm chrwm

@Ludee Ludee

Assignees

@stap-m stap-m

Labels
oeo-physical changes the oeo-physical module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add degree of electrification
2 participants
@stap-m @l-emele