-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum threshold for number of buffers #1858
Conversation
Yes, it is wiping dirt under doormat type of solution. |
Not sure if we want to go all the way to 64 as at least with the non-tls implementation this will actually have an impact on memory requirements ? |
Just in memory.c
i.e more 62 64-bit pointers (496 bytes) get pre-allocated for 1-CPU version |
Yes, but that's the experimental TLS version you are looking at - pretty sure that in the other/older/default implementation it corresponds to an actual allocation. |
The "old" version
|
Just looking for reasons why nobody tried to uncouple NUM_BUFFERS from NUM_CPU (NUM_THREADS) before, although this problem has come up in some form or other every few months in the past years. |
I think it is buffer (me) or two (formula there) per thread, the big issue is that single-threaded version depends on this structure at all. |
And dont break expectation that single-thread version can work in many threads.
#1847